[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3368: [CARBONDATA-3507] Fix Create Table As Select Failure in Spark-2.3

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3368: [CARBONDATA-3507] Fix Create Table As Select Failure in Spark-2.3

GitBox
ajantha-bhat commented on a change in pull request #3368: [CARBONDATA-3507] Fix Create Table As Select Failure in Spark-2.3
URL: https://github.com/apache/carbondata/pull/3368#discussion_r321689028
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
 ##########
 @@ -568,7 +568,7 @@ class CarbonFileMetastore extends CarbonMetaStore {
         val tableLocation = catalogTable.storage.locationUri match {
           case tableLoc@Some(uri) =>
             if (tableLoc.get.isInstanceOf[URI]) {
 
 Review comment:
   still need to check isInstanceOf[URI] ? we are not using it now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services