ajantha-bhat commented on a change in pull request #3410: [CARBONDATA-3552]Fix dataload failure for column added in 1.1 which is a sort column in latest version.
URL:
https://github.com/apache/carbondata/pull/3410#discussion_r337447921
##########
File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/holder/UnsafeSortTempFileChunkHolder.java
##########
@@ -105,18 +106,24 @@
* Constructor to initialize
*/
public UnsafeSortTempFileChunkHolder(File tempFile, SortParameters parameters,
- boolean convertNoSortFields) {
+ boolean convertNoSortFields, TableFieldStat tableFieldStat) {
// set temp file
this.tempFile = tempFile;
this.readBufferSize = parameters.getBufferSize();
this.compressorName = parameters.getSortTempCompressorName();
- this.tableFieldStat = new TableFieldStat(parameters);
+ this.tableFieldStat = tableFieldStat;
this.sortStepRowHandler = new SortStepRowHandler(tableFieldStat);
this.executorService = Executors.newFixedThreadPool(1);
- comparator = new IntermediateSortTempRowComparator(parameters.getNoDictionarySortColumn(),
- parameters.getNoDictDataType());
this.convertNoSortFields = convertNoSortFields;
this.sortTempRowUpdater = tableFieldStat.getSortTempRowUpdater();
+ if (!this.convertNoSortFields) {
Review comment:
Other two places, IntermediateSortTempRowComparator is directly replaced with FileMergeSortComparator.
Need to support old and new comparator for other two places also ?
If no need to handle other two places implies that new comparator handles it, so here also no need to handle ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
