[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

[GitBox]

ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r349087888
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
 ##########
 @@ -391,7 +391,12 @@ private static void setLocalDictInfo(CarbonTable table, TableInfo tableInfo) {
    */
   private void fillCreateOrderColumn(String tableName) {
     List<CarbonColumn> columns = new ArrayList<CarbonColumn>();
-    List<CarbonDimension> dimensions = this.tableDimensionsMap.get(tableName);
+    List<CarbonDimension> dimensions = new ArrayList<CarbonDimension>();
+    for (CarbonDimension dimension : this.tableDimensionsMap.get(tableName)) {
+      if (dimension.getColumnSchema().getSchemaOrdinal() != -1) {
 
 Review comment:
   **I checked, in multiple places getSchemaOrdinal = -1 is already used, that means -1 has some meaning. Please have a separate flag to identify instead of this.**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services