[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

[GitBox]

ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r349515090
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java
 ##########
 @@ -133,7 +134,11 @@ public static void processFilterExpression(FilterProcessVO processVO, Expression
       final boolean[] isFilterDimensions, final boolean[] isFilterMeasures,
       CarbonTable carbonTable) {
     if (null != filterExpression) {
-      if (null != filterExpression.getChildren() && filterExpression.getChildren().size() == 0) {
+      if (filterExpression instanceof PolygonExpression) {
+        /* Process polygon expression */
+        ((PolygonExpression) filterExpression).buildRangeExpression();
 
 Review comment:
   can buildRangeExpression during the constructor itself ? Better to do as soon as object is created.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services