[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

[GitBox]

ajantha-bhat commented on a change in pull request #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#discussion_r349547604
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/RowParserImpl.java
 ##########
 @@ -95,6 +111,11 @@ public RowParserImpl(DataField[] output, CarbonDataLoadConfiguration configurati
     }
     Object[] out = new Object[genericParsers.length];
     for (int i = 0; i < genericParsers.length; i++) {
+      if (inputMapping[i] == -1) {
+        /* All the non schema fields are placed at end. And input mapping for them are marked as -1.
+        Can break the loop when inputMapping[i] is -1. */
+        break;
+      }
 
 Review comment:
   ```
   if (inputMapping[i] == -1) {
           /* skip for non schema columns  */
           continue;
         }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services