[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3437: [CARBONDATA-3530] Support Create timeseries MV Datamap with the supported granularity levels.

[GitBox]

ajantha-bhat commented on a change in pull request #3437: [CARBONDATA-3530] Support Create timeseries MV Datamap with the supported granularity levels.
URL: https://github.com/apache/carbondata/pull/3437#discussion_r346296935
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/datamap/DataMapClassProvider.java
 ##########
 @@ -31,7 +31,8 @@
   TIMESERIES("org.apache.carbondata.core.datamap.TimeSeriesDataMap", "timeseries"),
   LUCENE("org.apache.carbondata.datamap.lucene.LuceneFineGrainDataMapFactory","lucene"),
   BLOOMFILTER("org.apache.carbondata.datamap.bloom.BloomCoarseGrainDataMapFactory", "bloomfilter"),
-  MV("org.apache.carbondata.core.datamap.MVDataMap", "mv");
+  MV("org.apache.carbondata.core.datamap.MVDataMap", "mv"),
+  MV_TIMESERIES("org.apache.carbondata.core.datamap.MVTimeSeriesDataMap", "mv_timeseries");
 
 Review comment:
   @Indhumathi27 : MV is a generic concept. It can handle any queries  (even timeseries). Timeseries is just a UDF. so  MVDataMap itself should handle this instead of adding new MVTimeSeriesDataMap

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services