ajantha-bhat commented on a change in pull request #3438: [CARBONDATA-3531]Support load and query for MV timeseries and support multiple granularity.
URL:
https://github.com/apache/carbondata/pull/3438#discussion_r346206470
##########
File path: core/src/main/java/org/apache/carbondata/core/preagg/TimeSeriesUDF.java
##########
@@ -119,10 +150,27 @@ private void initialize() {
if (TIMESERIES_FUNCTION.isEmpty()) {
TIMESERIES_FUNCTION.add("second");
TIMESERIES_FUNCTION.add("minute");
+ TIMESERIES_FUNCTION.add("five_minute");
+ TIMESERIES_FUNCTION.add("ten_minute");
+ TIMESERIES_FUNCTION.add("fifteen_minute");
+ TIMESERIES_FUNCTION.add("thirty_minute");
TIMESERIES_FUNCTION.add("hour");
TIMESERIES_FUNCTION.add("day");
+ TIMESERIES_FUNCTION.add("week");
TIMESERIES_FUNCTION.add("month");
TIMESERIES_FUNCTION.add("year");
}
+ int firstDayOfWeek;
+ try {
+ firstDayOfWeek = DaysOfWeekEnum.valueOf(CarbonProperties.getInstance()
+ .getProperty(CarbonCommonConstants.CARBON_TIMESERIES_FIRST_DAY_OF_WEEK,
+ CarbonCommonConstants.CARBON_TIMESERIES_FIRST_DAY_OF_WEEK_DEFAULT).toUpperCase())
+ .getOrdinal();
+ } catch (IllegalArgumentException ex) {
+ firstDayOfWeek = DaysOfWeekEnum.valueOf(CarbonProperties.getInstance()
Review comment:
Need to add log that user set wrong value in `CarbonCommonConstants.CARBON_TIMESERIES_FIRST_DAY_OF_WEEK` ?
or add it in validate carbon properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
