[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3438: [CARBONDATA-3531]Support load and query for MV timeseries and support multiple granularity.

[GitBox]

ajantha-bhat commented on a change in pull request #3438: [CARBONDATA-3531]Support load and query for MV timeseries and support multiple granularity.
URL: https://github.com/apache/carbondata/pull/3438#discussion_r346244424
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/Utils.scala
 ##########
 @@ -416,6 +416,30 @@ object Utils extends PredicateHelper {
     }
   }
 
+  private def canBeDerived(subsumer: ModularPlan, expE: Expression): Boolean = {
+    var canBeDerived = false
+    subsumer.asInstanceOf[Select].outputList.forall {
+      case Alias(s: ScalaUDF, _) =>
+        expE.children.foreach { expr =>
+          if (s.semanticEquals(expr)) {
+            canBeDerived = true
 
 Review comment:
   can directly return here and stop checking other expression if found ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services