[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3442: [HOTFIX] Remove unnecessary Map object in CarbonTable

[GitBox]

ajantha-bhat commented on a change in pull request #3442: [HOTFIX] Remove unnecessary Map object in CarbonTable
URL: https://github.com/apache/carbondata/pull/3442#discussion_r346922732
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java
 ##########
 @@ -68,11 +68,11 @@
 
   private int maxValue;
 
-  private CarbonDimension dimension;
 
 Review comment:
   why this change ? dictionary is only generated for dimension columns right ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services