[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter

[GitBox]

ajantha-bhat commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter
URL: https://github.com/apache/carbondata/pull/3444#discussion_r349049932
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
 ##########
 @@ -217,6 +220,14 @@ public BitSet prunePages(RawBlockletColumnChunks rawBlockletColumnChunks)
           bitSet.set(i);
         }
       }
 
 Review comment:
   when `carbon.push.rowfilters.for.vector` = `true`,  This method won't be called.
   Need to handle same in
   ```
   applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
         boolean useBitsetPipeLine)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services