[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter

[GitBox]

ajantha-bhat commented on a change in pull request #3444: [CARBONDATA-3581] Support page level bloom filter
URL: https://github.com/apache/carbondata/pull/3444#discussion_r349434099
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/chunk/AbstractRawColumnChunk.java
 ##########
 @@ -54,6 +55,15 @@ public AbstractRawColumnChunk(int columnIndex, ByteBuffer rawData, long offSet,
     this.length = length;
   }
 
+  public ColumnPagesBloomFilter getPageBloomFilter() {
+    // page bloom is disabled for current column in this blocklet
+    if (!dataChunkV3.isSetPage_bloom_chunk()) {
+      return null;
+    } else {
 
 Review comment:
   ```suggestion
       if (!dataChunkV3.isSetPage_bloom_chunk()) {
         return null;
       }
       return new ColumnPagesBloomFilter(dataChunkV3.page_bloom_chunk);
   ```
   
   He means like above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services