[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3452: [CARBONDATA-3579] Support merging index files when adding new partition

[GitBox]

ajantha-bhat commented on a change in pull request #3452: [CARBONDATA-3579] Support merging index files when adding new partition
URL: https://github.com/apache/carbondata/pull/3452#discussion_r346714963
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala
 ##########
 @@ -205,13 +205,15 @@ case class AlterTableCompactionAbortEvent(sparkSession: SparkSession,
 /**
  * Compaction Event for handling merge index in alter DDL
  *
- * @param sparkSession
- * @param carbonTable
- * @param alterTableModel
+ * @param sparkSession spark session
+ * @param carbonTable carbon table
+ * @param alterTableModel alter request
+ * @param segments optional list of segments to perform index merge
  */
 case class AlterTableMergeIndexEvent(sparkSession: SparkSession,
     carbonTable: CarbonTable,
-    alterTableModel: AlterTableModel) extends Event with AlterTableCompactionEventInfo
+    alterTableModel: AlterTableModel,
 
 Review comment:
   AlterTableModel is already having `customSegmentIds`, why added a new argument. we can just use that ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services