ajantha-bhat commented on a change in pull request #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
URL:
https://github.com/apache/carbondata/pull/3481#discussion_r357054630
##########
File path: geo/src/main/java/org/apache/carbondata/geo/QuadTreeCls.java
##########
@@ -0,0 +1,904 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *
http://www.apache.org/licenses/LICENSE-2.0+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.geo;
+
+import java.awt.geom.Point2D;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.List;
+
+import org.apache.carbondata.common.logging.LogServiceFactory;
+
+import org.apache.log4j.Logger;
+
+import org.locationtech.jts.geom.Coordinate;
+import org.locationtech.jts.geom.Geometry;
+import org.locationtech.jts.geom.GeometryFactory;
+import org.locationtech.jts.geom.Point;
+import org.locationtech.jts.geom.Polygon;
+
+
+
+/**
+ * Spatial region function processing related classes
+ */
+class GeometryOperation {
+ private static final GeometryFactory geoFactory = new GeometryFactory();
+
+ /**
+ * Convert point object to polygon object in Geo
+ *
+ * @param polygon Area coordinates stored as a list
+ * @return JTS Polygon objects
+ */
+ public static Polygon getPolygonByPointList(List<Point2D.Double> polygon) {
+ int size = polygon.size();
+ if (size < 3) {
+ return null;
+ } else {
+ Coordinate[] rect = new Coordinate[size + 1];
+ for (int i = 0; i < size; i++) {
+ rect[i] = new Coordinate(polygon.get(i).x, polygon.get(i).y);
+ }
+ rect[size] = new Coordinate(polygon.get(0).x, polygon.get(0).y);
Review comment:
I know it is not mandatory for user to have same point for first and last. But if user gives the first and last point as same, we need not have to handle it. code should handle both the sceneario
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
