ajantha-bhat commented on a change in pull request #3496: [CARBONDATA-3601] Show Segments displays wrong Index size for Partition table with Merge Index Enabled
URL:
https://github.com/apache/carbondata/pull/3496#discussion_r354145034
##########
File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
##########
@@ -168,6 +168,9 @@ public void commitJob(JobContext context) throws IOException {
throw new IOException(e);
}
}
+ // After merging index, update newMetaEntry with updated data and index size
Review comment:
Line 156 also calling the API , now that values will be overwritten by this. so previous call is not required. Find segment is empty or not by some other API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
