[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3500: [CARBONDATA-3351]Block bloom datamap creation on binary datatype column

[GitBox]

ajantha-bhat commented on a change in pull request #3500: [CARBONDATA-3351]Block bloom datamap creation on binary datatype column
URL: https://github.com/apache/carbondata/pull/3500#discussion_r355804343
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
 ##########
 @@ -145,6 +146,12 @@ case class CarbonCreateDataMapCommand(
               "column '%s' already has %s index datamap created",
               column.getColName, thisDmProviderName))
           } else if (isBloomFilter) {
+            if (column.getDataType == DataTypes.BINARY) {
+              throw new MalformedDataMapCommandException(
+                s"BloomFilter datamap does not support Binary datatype column: ${
+                  column.getColName
+                }")
+            }
             // if datamap provider is bloomfilter,the index column datatype cannot be complex type
             if (column.isComplex) {
 
 Review comment:
   better to make it 'else if'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services