[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3502: [CARBONATA-3605] Remove global dictionary feature

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3502: [CARBONATA-3605] Remove global dictionary feature

GitBox
ajantha-bhat commented on a change in pull request #3502: [CARBONATA-3605] Remove global dictionary feature
URL: https://github.com/apache/carbondata/pull/3502#discussion_r361853423
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/CarbonLoadStatisticsImpl.java
 ##########
 @@ -314,9 +299,7 @@ private void printDicGenStatisticsInfo() {
     double loadCsvfilesToDfTime = getLoadCsvfilesToDfTime();
     LOGGER.info("STAGE 1 ->Load csv to DataFrame and generate" +
             " block distinct values: " + loadCsvfilesToDfTime + "(s)");
-    double dicShuffleAndWriteFileTotalTime = getDicShuffleAndWriteFileTotalTime();
-    LOGGER.info("STAGE 2 ->Global dict shuffle and write dict file: " +
-            dicShuffleAndWriteFileTotalTime + "(s)");
+    LOGGER.info("STAGE 2 ->Global dict shuffle and write dict file (deprecated): 0(s)");
 
 Review comment:
   better to remove this log itself

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services