[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3502: [CARBONATA-3605] Remove global dictionary feature

[GitBox]

ajantha-bhat commented on a change in pull request #3502: [CARBONATA-3605] Remove global dictionary feature
URL: https://github.com/apache/carbondata/pull/3502#discussion_r361854025
 
 

 ##########
 File path: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonObjectInspector.java
 ##########
 @@ -60,14 +60,16 @@ public CarbonObjectInspector(final StructTypeInfo rowTypeInfo) {
   }
 
   private ObjectInspector getObjectInspector(final TypeInfo typeInfo) {
-    if (typeInfo.equals(TypeInfoFactory.doubleTypeInfo)) {
+    if (typeInfo.equals(TypeInfoFactory.stringTypeInfo)) {
 
 Review comment:
   why this change and why move string up  ? assuming many columns will be string type ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services