[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

GitBox

ajantha-bhat commented on a change in pull request #3721:
URL: https://github.com/apache/carbondata/pull/3721#discussion_r415533124



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSLocalCarbonFile.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.filesystem;
+
+import org.apache.hadoop.fs.FileStatus;
+
+public class HDFSLocalCarbonFile extends HDFSCarbonFile {

Review comment:
       But I feel no need to keep dummy wrappers, based on `HDFS_LOCAL` file type we will know it is HDFS local.
   I suggest to remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]