[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

[GitBox]

ajantha-bhat commented on a change in pull request #3721:
URL: https://github.com/apache/carbondata/pull/3721#discussion_r415536894



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/DefaultFileTypeProvider.java
##########
@@ -110,6 +110,8 @@ public CarbonFile getCarbonFile(String path, Configuration conf) {
         return new AlluxioCarbonFile(path);
       case VIEWFS:
         return new ViewFSCarbonFile(path);
+      case HDFS_LOCAL:
+        return new HDFSCarbonFile(path);

Review comment:
       a. No need pass the conf ?
   b. If required to pass the conf,  please use fall through switch syntax for identical values.
         case HDFS:
         case HDFS_LOCAL:
           return new HDFSCarbonFile(path, conf);
   
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]