ajantha-bhat commented on a change in pull request #3818:
URL:
https://github.com/apache/carbondata/pull/3818#discussion_r457364156##########
File path: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonColumnVectorWrapper.java
##########
@@ -273,7 +279,7 @@ public boolean hasDictionary() {
@Override
public CarbonColumnVector getDictionaryVector() {
- return this.columnVector.getDictionaryVector();
+ return this.dictionaryVectorWrapper;
Review comment:
Currently in our code it is used only in `SliceStreamReader#buildBlock`.
I don't see any problem here.
Also in your issue JIRA, saw that it is in delete scenario. so may be this change is not applicable to our current code. **our version of carbon doesn't support insert delete from presto yet**. Feel free to contribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
