[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

[GitBox]

ajantha-bhat commented on a change in pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#discussion_r481808887



##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CSVCarbonWriter.java
##########
@@ -72,6 +88,75 @@ public void write(Object object) throws IOException {
     }
   }
 
+  private CsvParser buildCsvParser(Configuration conf) {
+    CsvParserSettings settings = CSVInputFormat.extractCsvParserSettings(conf);
+    return new CsvParser(settings);
+  }
+
+  @Override
+  public void validateAndSetDataFiles(CarbonFile[] dataFiles) throws IOException {

Review comment:
       check if this can be private




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]