[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

GitBox

ajantha-bhat commented on a change in pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#discussion_r481809389



##########
File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriter.java
##########
@@ -49,4 +50,11 @@ public static CarbonWriterBuilder builder() {
     return new CarbonWriterBuilder();
   }
 
+  public abstract void write() throws IOException;
+
+  /**
+   * To validate and set the list of carbon files.
+   */
+  public abstract void validateAndSetDataFiles(CarbonFile[] dataFiles) throws IOException;

Review comment:
       validation can be handled internally I guess, no need to expose interface




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]