ajantha-bhat opened a new pull request #3303: []Fix wrong results in preaggregate query with spark adaptive execution
URL:
https://github.com/apache/carbondata/pull/3303
problem: Wrong results in preaggregate query with spark adaptive execution
`Spark2TestQueryExecutor.conf.set(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key, "true")`
cause: For preaggreagate, segment info is set into threadLocal. when adaptive execution is called, spark is calling getInternalPartition in another thread where updated segment conf is not set. Hence it is not using the updated segments.
solution: CarbonScanRdd is already having the sessionInfo, use it instead of taking session info from the current thread.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? NA
- [ ] Any backward compatibility impacted? NA
- [ ] Document update required? NA
- [ ] Testing done
done. Updated UT.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
