[GitHub] [carbondata] ajantha-bhat opened a new pull request #3562: [WIP] complex child supports huge data

[GitBox]

ajantha-bhat opened a new pull request #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562
 
 
    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570796667
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1463/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570798572
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1464/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570805134
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1465/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570808753
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1466/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570813509
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1467/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570833887
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1468/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570859870
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1469/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570891356
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1472/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-570900138
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1477/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [WIP] complex child supports huge data
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-571089536
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1491/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562#discussion_r363559467
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ImageTest.java
 ##########
 @@ -1168,4 +1169,44 @@ public void writeCarbonFile(String path, int num) throws Exception {
     reader.close();
   }
 
+  @Test public void testHugeBinaryWithComplexType()
 
 Review comment:
   Can you also add a testcase to read the written files by CarbonSession?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Zhangshunyu commented on a change in pull request #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562#discussion_r363562083
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ImageTest.java
 ##########
 @@ -1168,4 +1169,44 @@ public void writeCarbonFile(String path, int num) throws Exception {
     reader.close();
   }
 
+  @Test public void testHugeBinaryWithComplexType()
 
 Review comment:
   yes, a testcase with sql statement using carbonsession needed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

niuge01 commented on issue #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-571406854
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562#discussion_r363575952
 
 

 ##########
 File path: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ImageTest.java
 ##########
 @@ -1168,4 +1169,44 @@ public void writeCarbonFile(String path, int num) throws Exception {
     reader.close();
   }
 
+  @Test public void testHugeBinaryWithComplexType()
 
 Review comment:
   ok. Added now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-571429771
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1496/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Zhangshunyu commented on issue #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562#issuecomment-571451720
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3562: [CARBONDATA-3653] Support huge data for complex child columns
URL: https://github.com/apache/carbondata/pull/3562
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services