[GitHub] [carbondata] ajantha-bhat opened a new pull request #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous

GitBox
ajantha-bhat opened a new pull request #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous
URL: https://github.com/apache/carbondata/pull/3577
 
 
    ### Why is this PR needed?
    Consider a scenario with complex columns[c1 int, c2 array<int>, c3 array<int>] here schema ordinal of child columns are -1. so c1, c2, c3 has ordinal 0, 1, 2. After alter table add column "c4 int", its ordinal should be 3. But currently it is 6 (due to flat column schema).
   This will give problem when this ordinal is  referred for some other functionality like rearrange projection columns.
   
    ### What changes were proposed in this PR?
   make schema ordinal continuous by collecting previous schema ordinal max.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous

GitBox
CarbonDataQA1 commented on issue #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous
URL: https://github.com/apache/carbondata/pull/3577#issuecomment-573992959
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1627/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous

GitBox
In reply to this post by GitBox
asfgit closed pull request #3577: [HOTFIX] Fix After alter table add column schemaOrdinal is not continuous
URL: https://github.com/apache/carbondata/pull/3577
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services