[GitHub] [carbondata] ajantha-bhat opened a new pull request #3645: [WIP] Fix insert failure on partition table with local sort

[GitBox]

ajantha-bhat commented on a change in pull request #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386205170
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ##########
 @@ -457,6 +534,34 @@ public static boolean isHeaderValid(String tableName, String[] csvHeader,
     return noDictSortAndNoSortTypes;
   }
 
+  /**
+   * Get the data types of the no dictionary sort columns as per dataFields order
 
 Review comment:
   I have analyzed already, The caller needs nodict mapping, I cannot change my functions. Then caller functions become non-readable. Later we have to refactor sort step and other places freshly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386864142
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ##########
 @@ -375,6 +375,25 @@ public static boolean isHeaderValid(String tableName, String[] csvHeader,
     return type.toArray(new DataType[type.size()]);
   }
 
+  /**
+   * get visible no dictionary dimensions as per data field order
+   *
+   * @param dataFields
+   * @return
+   */
+  public static DataType[] getNoDictDataTypesAsDataFieldOrder(DataField[] dataFields) {
+    List<DataType> type = new ArrayList<>();
+    for (DataField dataField : dataFields) {
 
 Review comment:
   This is base code. This file has same function with for loops.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386864499
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java
 ##########
 @@ -248,6 +248,23 @@ public void setSchemaUpdatedTimeStamp(long schemaUpdatedTimeStamp) {
     return type;
   }
 
+  public DataType[] getMeasureDataTypeAsDataFieldOrder() {
+    // same as data fields order
+    List<Integer> measureIndexes = new ArrayList<>(dataFields.length);
+    int measureCount = 0;
+    for (int i = 0; i < dataFields.length; i++) {
 
 Review comment:
   This is base code. This file has same function with for loops.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on issue #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#issuecomment-595052680
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on issue #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#issuecomment-595654337
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3645: [CARBONDATA-3728] Fix insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services