[GitHub] [carbondata] ajantha-bhat opened a new pull request #3807: [HOTFIX] Fix module problems of mv and spark with spark 2.4 profile

[GitBox]

ajantha-bhat opened a new pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807


    ### Why is this PR needed?
    After #3700 , spark binary version addition.
   a) Module name always taking deafult profile spark binary version.
   b)   IDE test cases are running with spark 2.3 even for spark2.3.4 because of above problem
   
    ### What changes were proposed in this PR?
   a)  keep a simple module name without binary version
   b) Use the package option with jar file name to have binary version in the final jar.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649391566


   @kunal642 , @akashrn5 : check it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat edited a comment on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649391566


   @kunal642 , @akashrn5 : please check it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649437666


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1492/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649439729


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3219/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649537393


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649581253


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1494/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-649583529


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3221/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

QiangCai commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659304203


   finalName is ${artifactId}-${version} by default, this change will not impact artifactId and version.
   Other modules will can not find the dependency: carbondata-spark_2.3 and carbondata-spark_2.4.
   
   actually, if you change spark.binary.version to 2.4 in pom.xml of the parent module, IDEA will work again for spark 2.4.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659305724


   @QiangCai : Developer should not manually modify pom to make it work for spark2.4.
   
   so I fixed like above.
   
   But some testcase failed to find CSV file after this change. so, I stopped it. Need to analyze why CSV files unable to find because of my change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat edited a comment on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659305724


   @QiangCai : Developer should not manually modify pom to make it work for spark2.4.
   After this PR both 2.4 and 2.5 works without any manual change and jar names also will have binary version.
   
   so I fixed like above.
   
   But some testcase failed to find CSV file after this change. so, I stopped it. Need to analyze why CSV files unable to find because of my change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659307068


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659338632


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1660/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659339600


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3403/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

QiangCai commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659829122


   @ajantha-bhat
   1. remove CarbonData jars from your local maven repo at first.
   2. build it with -o, you will find dependency error( can not find the dependency: carbondata-spark_2.3 and carbondata-spark_2.4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat edited a comment on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659305724


   @QiangCai : Developer should not manually modify pom to make it work for spark2.4.
   After this PR both 2.4 and 2.3 works without any manual change and jar names also will have binary version.
   
   so I fixed like above.
   
   But some testcase failed to find CSV file after this change. so, I stopped it. Need to analyze why CSV files unable to find because of my change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-725365765


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4794/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-725367090


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3036/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-725368537


   @QiangCai : I think it was failing because I have changed Artifact name without binary version but other module pom file dependency was still using binary version in artifcat id. It clicked me today. I have fixed it.
   You can check the PR @QiangCai , @kunal642


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat edited a comment on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-725368537


   @QiangCai : I think it was failing because I have changed Artifact name without binary version but other module pom file dependency was still using binary version in artifact id. It clicked me today. I have fixed it.
   You can check the PR @QiangCai , @kunal642


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]