[GitHub] [carbondata] ajantha-bhat opened a new pull request #3809: [WIP] Fix concurrent main table compaction and SI load issue

[GitBox]

ajantha-bhat opened a new pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809


    ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-650201645


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3226/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-650202504


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1498/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-651596439


   @akashrn5 : please check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-652824236


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-652896458


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3290/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

CarbonDataQA1 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-652896859


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1553/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

Indhumathi27 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-652998410


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

kunal642 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655331778


   @ajantha-bhat You have 2 more PR related to compationa and SI. Please make them under a unified PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

kunal642 edited a comment on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655331778


   @ajantha-bhat You have 2 more PR related to compaction and SI. Please make them under a unified PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655336376


   If other 2 you mean,
   3829 - just main table (**segment lock**) load and compaction concurrent issue
   3810 - SI missing and wrong **table status** locks
   And this PR is nothing to do with locks, it is a functional problem. so, I separated it out for better maintenance.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat edited a comment on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655336376


   @kunal642 If other 2 you mean,
   3829 - just main table (**segment lock**) load and compaction concurrent issue
   3810 - SI missing and wrong **table status** locks
   And this PR is nothing to do with locks, it is a functional problem. so, I separated it out for better maintenance.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

kunal642 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655340711


   All are similar issues(concurrent scenarios), so better the fix should also be in one PR for easy identification and maintenance.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655341495


   yeah, better to combine all to one, because all are found in concurrent executions with SI, so In PR description you can list the issue for better understanding and maintainannce


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

akashrn5 edited a comment on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-655341495


   yeah, better to combine all to one, because all are found in concurrent executions with SI, so In PR description you can list the issue for better understanding and maintenance


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat closed pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

ajantha-bhat commented on pull request #3809:
URL: https://github.com/apache/carbondata/pull/3809#issuecomment-658620378


   @kunal642 , @akashrn5 : combined all 3 in #3810


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]