ajantha-bhat commented on a change in pull request #3871:
URL:
https://github.com/apache/carbondata/pull/3871#discussion_r488608473##########
File path: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java
##########
@@ -233,15 +234,24 @@ public String writeMergeIndexFileBasedOnSegmentFile(String segmentId,
}
if (FileFactory.getCarbonFile(entry.getKey()).equals(FileFactory.getCarbonFile(location))) {
segment.getValue().setMergeFileName(mergeIndexFile);
- segment.getValue().setFiles(new HashSet<String>());
+ mergeIndexFiles
+ .add(entry.getKey() + CarbonCommonConstants.FILE_SEPARATOR + mergeIndexFile);
+ segment.getValue().setFiles(new HashSet<>());
break;
}
}
if (table.isHivePartitionTable()) {
for (PartitionSpec partitionSpec : partitionSpecs) {
if (partitionSpec.getLocation().toString().equals(partitionPath)) {
- SegmentFileStore.writeSegmentFile(table.getTablePath(), mergeIndexFile, partitionPath,
- segmentId + "_" + uuid + "", partitionSpec.getPartitions(), true);
+ try {
+ SegmentFileStore.writeSegmentFile(table.getTablePath(), mergeIndexFile, partitionPath,
+ segmentId + "_" + uuid + "", partitionSpec.getPartitions(), true);
+ } catch (Exception ex) {
+ // delete merge index file if created,
+ // keep only index files as segment file writing is failed
Review comment:
ok
##########
File path: core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java
##########
@@ -251,9 +261,29 @@ public String writeMergeIndexFileBasedOnSegmentFile(String segmentId,
String path = CarbonTablePath.getSegmentFilesLocation(table.getTablePath())
+ CarbonCommonConstants.FILE_SEPARATOR + newSegmentFileName;
if (!table.isHivePartitionTable()) {
- SegmentFileStore.writeSegmentFile(segmentFileStore.getSegmentFile(), path);
- SegmentFileStore.updateTableStatusFile(table, segmentId, newSegmentFileName,
+ String content = SegmentStatusManager.readFileAsString(path);
+ try {
+ SegmentFileStore.writeSegmentFile(segmentFileStore.getSegmentFile(), path);
+ } catch (Exception ex) {
+ // delete merge index file if created,
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
Locked
