[GitHub] [carbondata] akashrn5 commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MV/Preaggregate rules for Command

[GitBox]

akashrn5 commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MV/Preaggregate rules for Command
URL: https://github.com/apache/carbondata/pull/3124#discussion_r281897289
 
 

 ##########
 File path: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonAnalyzer.scala
 ##########
 @@ -40,12 +40,13 @@ class CarbonAnalyzer(catalog: SessionCatalog,
 
   override def execute(plan: LogicalPlan): LogicalPlan = {
     var logicalPlan = analyzer.execute(plan)
-    logicalPlan = CarbonPreAggregateDataLoadingRules(sparkSession).apply(logicalPlan)
-    logicalPlan = CarbonPreAggregateQueryRules(sparkSession).apply(logicalPlan)
-    if (mvPlan != null) {
-      mvPlan.apply(logicalPlan)
-    } else {
-      logicalPlan
+    if (!logicalPlan.isInstanceOf[Command] && !logicalPlan.isInstanceOf[DeserializeToObject]) {
 
 Review comment:
   @ravipesala i think, we need to add here, because isValidPlan comes after initializing datamap catalogs, so if no catalog found, it will create catalog and try to register schema, which will go to MV plan flow. so better to avoid this, can you please check once

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services