[GitHub] [carbondata] akashrn5 commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MV/Preaggregate rules for Command

[GitBox]

akashrn5 commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MV/Preaggregate rules for Command
URL: https://github.com/apache/carbondata/pull/3124#discussion_r281949700
 
 

 ##########
 File path: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonAnalyzer.scala
 ##########
 @@ -40,12 +40,13 @@ class CarbonAnalyzer(catalog: SessionCatalog,
 
   override def execute(plan: LogicalPlan): LogicalPlan = {
     var logicalPlan = analyzer.execute(plan)
-    logicalPlan = CarbonPreAggregateDataLoadingRules(sparkSession).apply(logicalPlan)
-    logicalPlan = CarbonPreAggregateQueryRules(sparkSession).apply(logicalPlan)
-    if (mvPlan != null) {
-      mvPlan.apply(logicalPlan)
-    } else {
-      logicalPlan
+    if (!logicalPlan.isInstanceOf[Command] && !logicalPlan.isInstanceOf[DeserializeToObject]) {
 
 Review comment:
   @ravipesala what i meant is, for example consider use database_name. There is no need of applying these rules for this command right. simply we go through that flow. So it is better to avoid right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services