[GitHub] [carbondata] akashrn5 commented on a change in pull request #3170: [HOTFIX]fixed loading issue for legacy store

[GitBox]

akashrn5 commented on a change in pull request #3170: [HOTFIX]fixed loading issue for legacy store
URL: https://github.com/apache/carbondata/pull/3170#discussion_r270815374
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java
 ##########
 @@ -84,19 +84,20 @@ private void addDimensions(List<CarbonDimension> dimensions) {
     List<DimensionSpec> dictDimensionSpec = new ArrayList<>();
     int dimIndex = 0;
     DimensionSpec spec;
-    short actualPosition = 0;
+    short dictActualPosition = 0;
+    short noDimActualPosition = 0;
 
 Review comment:
   done, please review and merge

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services