[GitHub] [carbondata] akashrn5 commented on a change in pull request #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

[GitBox]

akashrn5 commented on a change in pull request #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]
URL: https://github.com/apache/carbondata/pull/3179#discussion_r277216999
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapUtil.java
 ##########
 @@ -159,4 +159,12 @@ private static DistributableDataMapFormat createDataMapJob(CarbonTable carbonTab
     return ssm.getValidAndInvalidSegments();
   }
 
+  /**
+   * Check if carbonTable is mv datamap table
+   */
+  public static Boolean isMVdatamapTable(CarbonTable carbonTable) {
+    String isMVdatamapTable =
+        carbonTable.getTableInfo().getFactTable().getTableProperties().get("isMVdatamapTable");
+    return (isMVdatamapTable != null && Boolean.valueOf(isMVdatamapTable).equals(true));
 
 Review comment:
   no need of `Boolean.valueOf(isMVdatamapTable).equals(true)` just do `Boolean.valueOf(isMVdatamapTable)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services