[GitHub] [carbondata] akashrn5 commented on a change in pull request #3285: [CARBONDATA-3433]Fix MV issues related to duplicate columns, limit and constant columns

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3285: [CARBONDATA-3433]Fix MV issues related to duplicate columns, limit and constant columns

GitBox
akashrn5 commented on a change in pull request #3285: [CARBONDATA-3433]Fix MV issues related to duplicate columns, limit and constant columns
URL: https://github.com/apache/carbondata/pull/3285#discussion_r293368997
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
 ##########
 @@ -96,7 +104,8 @@ object MVHelper {
           children = None,
           rawSchema = rawSchema)
       }
-    }
+    }.distinct
 
 Review comment:
   yes, thanks for the input, i cross verified this, it remains same order, as distinct creates new set which contains the first occurance of every element of the input sequence. So if its a,b,b,c,c,d,e, after distinct it remains same order as a,b,c,d,e

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services