[GitHub] [carbondata] akashrn5 commented on a change in pull request #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql

[GitBox]

akashrn5 commented on a change in pull request #3357: [CARBONDATA-3491] Return updated/deleted rows count when execute update/delete sql
URL: https://github.com/apache/carbondata/pull/3357#discussion_r316623507
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForDeleteCommand.scala
 ##########
 @@ -104,24 +111,27 @@ private[sql] case class CarbonProjectForDeleteCommand(
       // handle the clean up of IUD.
       CarbonUpdateUtil.cleanUpDeltaFiles(carbonTable, false)
 
-      val deletedSegments = DeleteExecution.deleteDeltaExecution(
+      val (deletedSegments, deletedRowCountTemp) = DeleteExecution.deleteDeltaExecution(
         databaseNameOp,
         tableName,
         sparkSession,
         dataRdd,
         timestamp,
         isUpdateOperation = false,
         executorErrors)
+
+      // check whether it fails before execute horizontal compaction
 
 Review comment:
   This comment is not required here, if you want to add one , then it can be changed to `Check for any failures occured during delete delta execution`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services