[GitHub] [carbondata] akashrn5 commented on a change in pull request #3375: [CARBONDATA-3512]Index Server Enchantment

[GitBox]

akashrn5 commented on a change in pull request #3375: [CARBONDATA-3512]Index Server Enchantment
URL: https://github.com/apache/carbondata/pull/3375#discussion_r321583399
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala
 ##########
 @@ -105,6 +109,11 @@ object IndexServer extends ServerInterface {
         sparkSession.sparkContext.setLocalProperty("spark.jobGroup.id", request.getTaskGroupId)
         sparkSession.sparkContext
           .setLocalProperty("spark.job.description", request.getTaskGroupDesc)
+        // Fire Generic Event like ACLCheck..etc
 
 Review comment:
   if the event is getting fired only in get splits, one place, then better to make the operationContext as local variable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services