akashrn5 commented on a change in pull request #3386: [WIP] : Pre-priming cache
URL:
https://github.com/apache/carbondata/pull/3386#discussion_r326521345
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
##########
@@ -866,6 +867,37 @@ case class CarbonLoadDataCommand(
case _ =>
}
}
+
+ // Prepriming for Partition table here
+ val indexServerEnabled = CarbonProperties.getInstance().isDistributedPruningEnabled(
+ carbonLoadModel.getDatabaseName, carbonLoadModel.getTableName)
+ val prePrimingEnabled = CarbonProperties.getInstance().isIndexServerPrePrimingEnabled()
Review comment:
`indexServerEnabled ` and `prePrimingEnabled ` looks common in many places, better to add these two in utility and call the funtion directly inside if condition place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services