[GitHub] [carbondata] akashrn5 commented on a change in pull request #3436: [WIP]Geospatial Support: Modified to create and load table with invisible dimension sort column

[GitBox]

akashrn5 commented on a change in pull request #3436: [WIP]Geospatial Support: Modified to create and load table with invisible dimension sort column
URL: https://github.com/apache/carbondata/pull/3436#discussion_r345032445
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala
 ##########
 @@ -53,6 +53,21 @@ private[sql] case class CarbonDescribeFormattedCommand(
       (field.name, field.dataType.simpleString, colComment)
     }
 
+    /* Append non-schema columns */
+    val columns = relation.carbonTable.getTableInfo.getFactTable.getListOfColumns.asScala
+    val implicitColumns = for (column <- columns if column.getSchemaOrdinal == -1) yield {
 
 Review comment:
   can you use filter here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services