[GitHub] [carbondata] akashrn5 commented on a change in pull request #3438: [CARBONDATA-3531]Support load and query for MV timeseries and support multiple granularity.

[GitBox]

akashrn5 commented on a change in pull request #3438: [CARBONDATA-3531]Support load and query for MV timeseries and support multiple granularity.
URL: https://github.com/apache/carbondata/pull/3438#discussion_r346334752
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/preagg/TimeSeriesFunctionEnum.java
 ##########
 @@ -23,10 +23,15 @@
 public enum TimeSeriesFunctionEnum {
   SECOND("second", 0),
   MINUTE("minute", 1),
-  HOUR("hour", 2),
-  DAY("day", 3),
-  MONTH("month", 4),
-  YEAR("year", 5);
+  FIVE_MINUTE("five_minute", 2),
+  TEN_MINUTE("ten_minute", 3),
+  FIFTEEN_MINUTE("fifteen_minute", 4),
+  THIRTY_MINUTE("thirty_minute", 5),
 
 Review comment:
   no, because we always get the enum with name, so there wont be problem for compatibility, since timeseries was never used before, this will be the first time, so no problem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services