[GitHub] [carbondata] akashrn5 commented on a change in pull request #3449: [CARBONDATA-3578] Make table status file smaller

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3449: [CARBONDATA-3578] Make table status file smaller

GitBox
akashrn5 commented on a change in pull request #3449: [CARBONDATA-3578] Make table status file smaller
URL: https://github.com/apache/carbondata/pull/3449#discussion_r346731108
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatus.java
 ##########
 @@ -58,7 +58,7 @@
   /**
    * Segment is compacted
    */
-  @SerializedName("Compacted")
+  @SerializedName(value = "C", alternate = "Compacted")
 
 Review comment:
   yes you are right, but i think since goal is to reduce size, better to change all the status, because when we have both status, like one with short form, one with full name do not look good, what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services