[GitHub] [carbondata] akashrn5 commented on a change in pull request #3496: [CARBONDATA-3601] Show Segments displays wrong Index size for Partition table with Merge Index Enabled

[GitBox]

akashrn5 commented on a change in pull request #3496: [CARBONDATA-3601] Show Segments displays wrong Index size for Partition table with Merge Index Enabled
URL: https://github.com/apache/carbondata/pull/3496#discussion_r355277195
 
 

 ##########
 File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
 ##########
 @@ -168,6 +168,9 @@ public void commitJob(JobContext context) throws IOException {
           throw new IOException(e);
         }
       }
+      // After merging index, update newMetaEntry with updated data and index size
 
 Review comment:
   that call is before merging the index file right, so once job is committed, we need to update the the size, and then after merge index we need to again do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services