[GitHub] [carbondata] akashrn5 commented on a change in pull request #3497: [CARBONDATA-3602]Fix MV issues with session level operations

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3497: [CARBONDATA-3602]Fix MV issues with session level operations

GitBox
akashrn5 commented on a change in pull request #3497: [CARBONDATA-3602]Fix MV issues with session level operations
URL: https://github.com/apache/carbondata/pull/3497#discussion_r364075233
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala
 ##########
 @@ -83,8 +83,16 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends Rule[LogicalPlan] {
         }
         Aggregate(grp, aExp, child)
     }
-    val catalog = DataMapStoreManager.getInstance().getDataMapCatalog(dataMapProvider,
+    var catalog = DataMapStoreManager.getInstance().getDataMapCatalog(dataMapProvider,
       DataMapClassProvider.MV.getShortName).asInstanceOf[SummaryDatasetCatalog]
+    // when first time DataMapCatalogs are initialized, it stores session info also, but when carbon
 
 Review comment:
   This is map stored in memory right, even if you initialize in carbonenv, every new session we need to clear and reload again. may be we might have better integration, but if we change integration test will take, may be we can take up this later

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services