[GitHub] [carbondata] akashrn5 commented on a change in pull request #3506: Prepriming fixes

[GitBox]

akashrn5 commented on a change in pull request #3506: Prepriming fixes
URL: https://github.com/apache/carbondata/pull/3506#discussion_r356416045
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/indexserver/PrePrimingListener.scala
 ##########
 @@ -40,7 +43,15 @@ object PrePrimingEventListener extends OperationEventListener {
       false,
       true)
     if (prePrimingEvent.segment.length != 0) {
-      IndexServer.getClient.getCount(dataMapFormat)
+      try {
+        IndexServer.getClient.getCount(dataMapFormat)
+      }
+      catch {
+        case ex: Exception =>
+          ex.printStackTrace()
+          LOGGER
+            .info("Connection to Index Server Failed. Loading without prepriming in Index Server")
 
 Review comment:
   it may not be always the connection issue, since pre priming is an additional optimization, if it fails, we just go ahead by telling the error. So you can just say, pre-priming to specific table failed and print log error like above. Please add a scenarios in comment as example when it might fail

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services