[GitHub] [carbondata] akashrn5 commented on a change in pull request #3511: [CARBONDATA-3620]: Update does not load cache in memory, behavior inconsistent with scenario when index server is not running

[GitBox]

akashrn5 commented on a change in pull request #3511: [CARBONDATA-3620]: Update does not load cache in memory, behavior inconsistent with scenario when index server is not running
URL: https://github.com/apache/carbondata/pull/3511#discussion_r359215727
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ##########
 @@ -473,6 +473,13 @@ object CarbonDataRDDFactory {
             .STATUS_FILE_UPDATION_FAILURE
           return null
         }
+        // code to handle Pre-Priming cache for update command
 
 Review comment:
   may be you can remove the empty if block above this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services