[GitHub] [carbondata] akashrn5 commented on a change in pull request #3707: [HOTFIX] Refactor code to optimize partition pruning

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3707: [HOTFIX] Refactor code to optimize partition pruning

GitBox

akashrn5 commented on a change in pull request #3707:
URL: https://github.com/apache/carbondata/pull/3707#discussion_r413545356



##########
File path: core/src/main/java/org/apache/carbondata/core/index/TableIndex.java
##########
@@ -187,8 +191,18 @@ public CarbonTable getTable() {
     return blocklets;
   }
 
+  private Set<Path> getPartitionsToPrune(List<PartitionSpec> partitionSpecs) {

Review comment:
       i think its better to rename the method name as `getPartionLocations`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]