[GitHub] [carbondata] akashrn5 opened a new pull request #3285: [CARBONDATA-3433]Fix MV issues related to duplicate columns, limit and constant columns

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 opened a new pull request #3285: [CARBONDATA-3433]Fix MV issues related to duplicate columns, limit and constant columns

GitBox
akashrn5 opened a new pull request #3285: [CARBONDATA-3433]Fix MV issues related to duplicate columns, limit and constant columns
URL: https://github.com/apache/carbondata/pull/3285
 
 
   ### Problem:
   MV has below issues:
   1. when has duplicate columns in select query, MV creation fails, but select is valid query
   2. when used constant column in ctas for datamap creation, it fails
   3. when limit is used in ctas for datamap creation, it fails
   
   ### Solution:
   1. since duplicate columns in query is valid, MV should support, so when creating columns, better take distinct columns
   2. handle getting field relation map when we have constant column in query
   3. block MV creation for limit ctas query, as it is not a valid case to use MV datamap.
   
   
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [x] Any interfaces changed?
    NA
    - [x] Any backward compatibility impacted?
    NA
    - [x] Document update required?
   NA
    - [x] Testing done
         added UT
     Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
         
    - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   NA
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services