[GitHub] [carbondata] akashrn5 opened a new pull request #3689: [WIP]add Secondary Index Document

classic Classic list List threaded Threaded
64 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
Indhumathi27 commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401528603
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,182 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
 
 Review comment:
   NO. We have added syntax as well. For MV,BLOOM,LUCENE, create syntax can be found in [https://github.com/apache/carbondata/blob/master/docs/index/index-management.md](https://github.com/apache/carbondata/blob/master/docs/index/index-management.md)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
akashrn5 commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401547146
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,182 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
 
 Review comment:
   added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607232094
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/898/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607266226
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2606/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401714678
 
 

 ##########
 File path: docs/configuration-parameters.md
 ##########
 @@ -147,6 +148,8 @@ This section provides the details of all the configurations required for the Car
 | carbon.query.stage.input.enable | false | Stage input files are data files written by external applications (such as Flink), but have not been loaded into carbon table. Enabling this configuration makes query to include these files, thus makes query on latest data. However, since these files are not indexed, query maybe slower as full scan is required for these files. |
 | carbon.driver.pruning.multi.thread.enable.files.count | 100000 | To prune in multi-thread when total number of segment files for a query increases beyond the configured value. |
 | carbon.load.all.segment.indexes.to.cache | true | Setting this configuration to false, will prune and load only matched segment indexes to cache using segment metadata information such as columnid and it's minmax values, which decreases the usage of driver memory.  |
+| carbon.secondary.index.creation.threads | 1 | Specifies the number of threads to concurrently process segments during secondary index creation. This property helps fine tuning the system when there are a lot of segments in a table. The value range is 1 to 50. |
 
 Review comment:
   looks like this is unused property, couldn't find usage. can we remove it from code also ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
akashrn5 commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401720641
 
 

 ##########
 File path: docs/configuration-parameters.md
 ##########
 @@ -147,6 +148,8 @@ This section provides the details of all the configurations required for the Car
 | carbon.query.stage.input.enable | false | Stage input files are data files written by external applications (such as Flink), but have not been loaded into carbon table. Enabling this configuration makes query to include these files, thus makes query on latest data. However, since these files are not indexed, query maybe slower as full scan is required for these files. |
 | carbon.driver.pruning.multi.thread.enable.files.count | 100000 | To prune in multi-thread when total number of segment files for a query increases beyond the configured value. |
 | carbon.load.all.segment.indexes.to.cache | true | Setting this configuration to false, will prune and load only matched segment indexes to cache using segment metadata information such as columnid and it's minmax values, which decreases the usage of driver memory.  |
+| carbon.secondary.index.creation.threads | 1 | Specifies the number of threads to concurrently process segments during secondary index creation. This property helps fine tuning the system when there are a lot of segments in a table. The value range is 1 to 50. |
 
 Review comment:
   its used, please refer org.apache.spark.sql.secondaryindex.rdd.SecondaryIndexCreator#getThreadPoolSize

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401741063
 
 

 ##########
 File path: docs/configuration-parameters.md
 ##########
 @@ -147,6 +148,8 @@ This section provides the details of all the configurations required for the Car
 | carbon.query.stage.input.enable | false | Stage input files are data files written by external applications (such as Flink), but have not been loaded into carbon table. Enabling this configuration makes query to include these files, thus makes query on latest data. However, since these files are not indexed, query maybe slower as full scan is required for these files. |
 | carbon.driver.pruning.multi.thread.enable.files.count | 100000 | To prune in multi-thread when total number of segment files for a query increases beyond the configured value. |
 | carbon.load.all.segment.indexes.to.cache | true | Setting this configuration to false, will prune and load only matched segment indexes to cache using segment metadata information such as columnid and it's minmax values, which decreases the usage of driver memory.  |
+| carbon.secondary.index.creation.threads | 1 | Specifies the number of threads to concurrently process segments during secondary index creation. This property helps fine tuning the system when there are a lot of segments in a table. The value range is 1 to 50. |
 
 Review comment:
   I see, IDE it was showing grey. Indexing problem may be

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401745203
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
+   AS
+   'carbondata'
+   TBLPROPERTIES('table_blocksize'='1')
+   ```
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
+  User can create SI table using the Create Index DDL
+
+  ```
+  CREATE INDEX index_sales
+  ON TABLE sales(user_id)
+  AS
+  'carbondata'
+  TBLPROPERTIES('table_blocksize'='1')
+  ```
+**NOTE**:
+ * Secondary Index tables are registered with hive and stored in HiveSERDEPROPERTIES as json formatted
+ value. Maximum characters supported for SERDEPROPERTIES by hive is 4000 characters which cannot be
+ changed.
+
+
+#### How SI tables are selected
+
+When a user executes a filter query, during query planning phase, CarbonData with help of
+CarbonSITransformationRule, checks if there are any index tables present on the filter column of
+query. If there are any, then filter query plan will be transformed such a way that, execution will
+first hit the corresponding SI table and give input to main table for further pruning.
+
+
+For the main table **sales** and SI table  **index_sales** created above, following queries
+```
+SELECT country, sex from sales where user_id = 'xxx'
+
+SELECT country, sex from sales where user_id = 'xxx' and country = 'INDIA'
+```
+
+will be transformed by CarbonData's CarbonSITransformationRule to query against SI table
+**index_sales** first which will be input to the main table **sales**
+
+
+## Loading data
+
+### Loading data to Secondary Index table(s).
+
+*case1:* When SI table is created and the main table does not have any data. In this case every
+consecutive load will load to SI table once main table data load is finished.
+
+*case2:* When SI table is created and main table already contains some data, then SI creation will
+also load to SI table with same number of segments as main table. There after, consecutive load to
+main table will load to SI table also.
+
+ **NOTE**:
+ * In case of any failure to SI table, then we make the SI table disable by setting a hive serde
+ property. The subsequent main table load will load the old failed loads along with current load and
+ makes the SI table enable and available for query.
+
+## Querying data
+Direct query can be made on SI tables to see the data present in position reference columns.
+When a filter query is fired, if the filter column is a secondary index column, then plan is
+transformed accordingly to hit SI table first to make better pruning with main table and in turn
+helps for faster query results.
+
+User can verify whether a query can leverage SI table or not by executing `EXPLAIN`
+command, which will show the transformed logical plan, and thus user can check whether SI table
+table is selected.
+
+
+## Compacting SI table
+
+### Compacting SI table table through Main Table compaction
+Running Compaction command (`ALTER TABLE COMPACT`)[COMPACTION TYPE-> MINOR/MAJOR] on main table will
+automatically delete all the old segments of SI and creates a new segment with same name as main
+table compacted segmet and loads data to it.
+
+### Compacting SI table's individual segment(s) through REBUILD command
+Where there are so many small files present in the SI table, then we can use REBUILD command to
+compact the files within an SI segment to avoid many small files.
+
+  ```
+  REBUILD INDEX sales_index
+  ```
+This command merges data files in  each segment of SI table.
+
+  ```
+  REBUILD INDEX sales_index WHERE SEGMENT.ID IN(1)
+  ```
+This command merges data files within specified segment of SI table.
+
+## How to skip Secondary Index?
+When Secondary indexes are created on a table(s), always data fetching happens from secondary
+indexes created on the maintables for better performance. But sometimes, data fetching from the
+secondary index might degrade query performance. So to avoid such secondary indexes, we use NI as a
 
 Review comment:
   can mention when it will be degraded.
   For example, when the data is sparse and most of the blocklet need to be scanned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401747847
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
+   AS
+   'carbondata'
+   TBLPROPERTIES('table_blocksize'='1')
+   ```
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
+  User can create SI table using the Create Index DDL
+
+  ```
+  CREATE INDEX index_sales
+  ON TABLE sales(user_id)
+  AS
+  'carbondata'
+  TBLPROPERTIES('table_blocksize'='1')
+  ```
+**NOTE**:
+ * Secondary Index tables are registered with hive and stored in HiveSERDEPROPERTIES as json formatted
+ value. Maximum characters supported for SERDEPROPERTIES by hive is 4000 characters which cannot be
+ changed.
+
+
+#### How SI tables are selected
+
+When a user executes a filter query, during query planning phase, CarbonData with help of
+CarbonSITransformationRule, checks if there are any index tables present on the filter column of
+query. If there are any, then filter query plan will be transformed such a way that, execution will
+first hit the corresponding SI table and give input to main table for further pruning.
+
+
+For the main table **sales** and SI table  **index_sales** created above, following queries
+```
+SELECT country, sex from sales where user_id = 'xxx'
+
+SELECT country, sex from sales where user_id = 'xxx' and country = 'INDIA'
+```
+
+will be transformed by CarbonData's CarbonSITransformationRule to query against SI table
+**index_sales** first which will be input to the main table **sales**
+
+
+## Loading data
+
+### Loading data to Secondary Index table(s).
+
+*case1:* When SI table is created and the main table does not have any data. In this case every
+consecutive load will load to SI table once main table data load is finished.
+
+*case2:* When SI table is created and main table already contains some data, then SI creation will
+also load to SI table with same number of segments as main table. There after, consecutive load to
+main table will load to SI table also.
+
+ **NOTE**:
+ * In case of any failure to SI table, then we make the SI table disable by setting a hive serde
 
 Review comment:
   ```suggestion
    * In case of any failure to SI table, then we make the SI table disable by setting a hive serde
   ```
   If data loading fails for SI table,

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401748755
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
+   AS
+   'carbondata'
+   TBLPROPERTIES('table_blocksize'='1')
+   ```
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
+  User can create SI table using the Create Index DDL
+
+  ```
+  CREATE INDEX index_sales
+  ON TABLE sales(user_id)
+  AS
+  'carbondata'
+  TBLPROPERTIES('table_blocksize'='1')
+  ```
+**NOTE**:
+ * Secondary Index tables are registered with hive and stored in HiveSERDEPROPERTIES as json formatted
+ value. Maximum characters supported for SERDEPROPERTIES by hive is 4000 characters which cannot be
+ changed.
+
+
+#### How SI tables are selected
+
+When a user executes a filter query, during query planning phase, CarbonData with help of
+CarbonSITransformationRule, checks if there are any index tables present on the filter column of
+query. If there are any, then filter query plan will be transformed such a way that, execution will
+first hit the corresponding SI table and give input to main table for further pruning.
+
+
+For the main table **sales** and SI table  **index_sales** created above, following queries
+```
+SELECT country, sex from sales where user_id = 'xxx'
+
+SELECT country, sex from sales where user_id = 'xxx' and country = 'INDIA'
+```
+
+will be transformed by CarbonData's CarbonSITransformationRule to query against SI table
 
 Review comment:
   for class names use code style presentation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401749949
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
+   AS
+   'carbondata'
+   TBLPROPERTIES('table_blocksize'='1')
+   ```
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
+  User can create SI table using the Create Index DDL
+
+  ```
+  CREATE INDEX index_sales
+  ON TABLE sales(user_id)
+  AS
+  'carbondata'
+  TBLPROPERTIES('table_blocksize'='1')
+  ```
+**NOTE**:
+ * Secondary Index tables are registered with hive and stored in HiveSERDEPROPERTIES as json formatted
+ value. Maximum characters supported for SERDEPROPERTIES by hive is 4000 characters which cannot be
+ changed.
 
 Review comment:
   as user will not register it manually, this information is irrelevant ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401753444
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
+   AS
+   'carbondata'
+   TBLPROPERTIES('table_blocksize'='1')
 
 Review comment:
   can you make table properties also optional  [] ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401754918
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
 
 Review comment:
   on table is not optional, don't use it in []

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on a change in pull request #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#discussion_r401755706
 
 

 ##########
 File path: docs/index/secondary-index-guide.md
 ##########
 @@ -0,0 +1,192 @@
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to you under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
+
+# CarbonData Secondary Index
+
+* [Quick Example](#quick-example)
+* [Secondary Index Table](#Secondary-Index-Introduction)
+* [Loading Data](#loading-data)
+* [Querying Data](#querying-data)
+* [Compaction](#compacting-SI-table)
+* [DDLs on Secondary Index](#DDLs-on-Secondary-Index)
+
+## Quick example
+
+Start spark-sql in terminal and run the following queries,
+```
+CREATE TABLE maintable(a int, b string, c string) stored as carbondata;
+insert into maintable select 1, 'ab', 'cd';
+CREATE index inex1 on table maintable(c) AS 'carbondata';
+SELECT a from maintable where c = 'cd';
+// NOTE: run explain query and check if query hits the SI table from the plan
+EXPLAIN SELECT a from maintable where c = 'cd';
+```
+
+## Secondary Index Introduction
+  Sencondary index tables are created as a indexes and managed as child tables internally by
+  Carbondata. Users can create secondary index based on the column position in main table(Recommended
+  for right columns) and the queries should have filter on that column to improve the filter query
+  performance.
+  
+  SI tables will always be loaded non-lazy way. Once SI table is created, Carbondata's
+  CarbonOptimizer with the help of CarbonSITransformationRule, transforms the query plan to hit the
+  SI table based on the filter condition or set of filter conditions present in the query.
+  So first level of pruning will be done on SI table as it stores blocklets and main table/parent
+  table pruning will be based on the SI output, which helps in giving the faster query results with
+  better pruning.
+
+  Secondary Index table can be create with below syntax
+
+   ```
+   CREATE INDEX [IF NOT EXISTS] index_name
+   [ON TABLE maintable](index_column)
+   AS
+   'carbondata'
+   TBLPROPERTIES('table_blocksize'='1')
+   ```
+  For instance, main table called **sales** which is defined as
+
+  ```
+  CREATE TABLE sales (
+    order_time timestamp,
+    user_id string,
+    sex string,
+    country string,
+    quantity int,
+    price bigint)
+  STORED AS carbondata
+  ```
+
+  User can create SI table using the Create Index DDL
+
+  ```
+  CREATE INDEX index_sales
+  ON TABLE sales(user_id)
+  AS
+  'carbondata'
+  TBLPROPERTIES('table_blocksize'='1')
+  ```
+**NOTE**:
+ * Secondary Index tables are registered with hive and stored in HiveSERDEPROPERTIES as json formatted
+ value. Maximum characters supported for SERDEPROPERTIES by hive is 4000 characters which cannot be
+ changed.
+
+
+#### How SI tables are selected
+
+When a user executes a filter query, during query planning phase, CarbonData with help of
+CarbonSITransformationRule, checks if there are any index tables present on the filter column of
+query. If there are any, then filter query plan will be transformed such a way that, execution will
+first hit the corresponding SI table and give input to main table for further pruning.
+
+
+For the main table **sales** and SI table  **index_sales** created above, following queries
+```
+SELECT country, sex from sales where user_id = 'xxx'
+
+SELECT country, sex from sales where user_id = 'xxx' and country = 'INDIA'
+```
+
+will be transformed by CarbonData's CarbonSITransformationRule to query against SI table
+**index_sales** first which will be input to the main table **sales**
+
+
+## Loading data
+
+### Loading data to Secondary Index table(s).
+
+*case1:* When SI table is created and the main table does not have any data. In this case every
+consecutive load will load to SI table once main table data load is finished.
+
+*case2:* When SI table is created and main table already contains some data, then SI creation will
+also load to SI table with same number of segments as main table. There after, consecutive load to
+main table will load to SI table also.
+
+ **NOTE**:
+ * In case of any failure to SI table, then we make the SI table disable by setting a hive serde
+ property. The subsequent main table load will load the old failed loads along with current load and
+ makes the SI table enable and available for query.
+
+## Querying data
+Direct query can be made on SI tables to see the data present in position reference columns.
+When a filter query is fired, if the filter column is a secondary index column, then plan is
+transformed accordingly to hit SI table first to make better pruning with main table and in turn
+helps for faster query results.
+
+User can verify whether a query can leverage SI table or not by executing `EXPLAIN`
+command, which will show the transformed logical plan, and thus user can check whether SI table
+table is selected.
+
+
+## Compacting SI table
+
+### Compacting SI table table through Main Table compaction
+Running Compaction command (`ALTER TABLE COMPACT`)[COMPACTION TYPE-> MINOR/MAJOR] on main table will
+automatically delete all the old segments of SI and creates a new segment with same name as main
+table compacted segmet and loads data to it.
+
+### Compacting SI table's individual segment(s) through REBUILD command
+Where there are so many small files present in the SI table, then we can use REBUILD command to
+compact the files within an SI segment to avoid many small files.
+
+  ```
+  REBUILD INDEX sales_index
+  ```
+This command merges data files in  each segment of SI table.
+
+  ```
+  REBUILD INDEX sales_index WHERE SEGMENT.ID IN(1)
+  ```
+This command merges data files within specified segment of SI table.
+
+## How to skip Secondary Index?
+When Secondary indexes are created on a table(s), always data fetching happens from secondary
+indexes created on the maintables for better performance. But sometimes, data fetching from the
+secondary index might degrade query performance. So to avoid such secondary indexes, we use NI as a
+function on flters with in WHERE clause.
+
+  ```
+  SELECT country, sex from sales where NI(user_id = 'xxx')
+  ```
+The above query ignores column user_id from secondary index and fetch data from main table.
+
+## DDLs on Secondary Index
+
+### Show index Command
+This command is used to get information about all the secondary indexes on a table.
+
+Syntax
+  ```
+  SHOW INDEXES  on [db_name.]table_name
+  ```
+
+### Drop index Command
+This command is used to drop an existing secondary index on a table
+
+Syntax
+  ```
+  DROP INDEX IF EXISTS index_name on [db_name.]table_name
 
 Review comment:
   keep If Exists in optional []

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
akashrn5 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607391866
 
 
   @ajantha-bhat handled all comments, please check

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607466069
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/906/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
CarbonDataQA1 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607468373
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2615/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607640854
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] ajantha-bhat commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
ajantha-bhat commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607801972
 
 
   @akashrn5 : one small suggestion. please add a link to `secondary-index-guide.md` in `README.md`
   because all other index features has link in README.md
   
   keep separate commit, I will merge after that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akashrn5 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document

GitBox
In reply to this post by GitBox
akashrn5 commented on issue #3689: [CARBONDATA-3680]Add Secondary Index Document
URL: https://github.com/apache/carbondata/pull/3689#issuecomment-607806461
 
 
   > @akashrn5 : one small suggestion. please add a link to `secondary-index-guide.md` in `README.md`
   > because all other index features has link in README.md
   >
   > keep separate commit, I will merge after that
   
   i ave added in separate commit, please check

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
1234