[GitHub] [carbondata] akashrn5 opened a new pull request #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance

[GitBox]

akashrn5 opened a new pull request #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691
 
 
    ### Why is this PR needed?
    Prefetch was set to false explicitly.
   
    ### What changes were proposed in this PR?
   Improve the query performance with prefetch enabled
       
    ### Does this PR introduce any user interface change?
    - No
   
   
    ### Is any new testcase added?
    - No
   TPCDS queries executed and some queries time was improved by almost 50%
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#discussion_r401695885
 
 

 ##########
 File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbondataPageSource.java
 ##########
 @@ -356,7 +356,6 @@ private PrestoCarbonVectorizedRecordReader createReaderForColumnar(HiveSplit car
     QueryModel queryModel = createQueryModel(carbonSplit, tableHandle, columns, conf);
     if (isDirectVectorFill) {
       queryModel.setDirectVectorFill(true);
-      queryModel.setPreFetchData(false);
 
 Review comment:
   @QiangCai : During streaming support for presto [#3001]
   you made prefetch as false.
   Any particular reason or issue you found with that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#issuecomment-607374347
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2611/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#issuecomment-607385939
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/903/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#issuecomment-607640002
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#issuecomment-607696268
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/908/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#issuecomment-607699019
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2617/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

QiangCai commented on a change in pull request #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#discussion_r402176992
 
 

 ##########
 File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbondataPageSource.java
 ##########
 @@ -356,7 +356,6 @@ private PrestoCarbonVectorizedRecordReader createReaderForColumnar(HiveSplit car
     QueryModel queryModel = createQueryModel(carbonSplit, tableHandle, columns, conf);
     if (isDirectVectorFill) {
       queryModel.setDirectVectorFill(true);
-      queryModel.setPreFetchData(false);
 
 Review comment:
   No, we can enable it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#discussion_r402226977
 
 

 ##########
 File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/CarbondataPageSource.java
 ##########
 @@ -356,7 +356,6 @@ private PrestoCarbonVectorizedRecordReader createReaderForColumnar(HiveSplit car
     QueryModel queryModel = createQueryModel(carbonSplit, tableHandle, columns, conf);
     if (isDirectVectorFill) {
       queryModel.setDirectVectorFill(true);
-      queryModel.setPreFetchData(false);
 
 Review comment:
   ok. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691#issuecomment-607775230
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3691: [CARBONDATA-3760]Enable prefetch in presto to improve query performance
URL: https://github.com/apache/carbondata/pull/3691
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services