[GitHub] [carbondata] akashrn5 opened a new pull request #3718: [CARBONDATA-3680]Add NI as a function not as udf

[GitBox]

akashrn5 opened a new pull request #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718
 
 
    ### Why is this PR needed?
    NI is registered as udf, so it is handled for both case of scalaUDF and HiveSimpleUDF
   
    ### What changes were proposed in this PR?
   Register NI as a functionand remove unwanted case for ScalaUDF for NI functionality.
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No(existing text cases will take care)
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615103751
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1048/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615112702
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2761/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#discussion_r410550755
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##########
 @@ -74,7 +75,13 @@ class CarbonEnv {
 
     sparkSession.udf.register("getTupleId", () => "")
     sparkSession.udf.register("getPositionId", () => "")
-    sparkSession.udf.register("NI", (anyRef: AnyRef) => true)
+    CreateFunctionCommand(None,
 
 Review comment:
   move None to next line and give parameter name for all parameters

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

jackylk commented on a change in pull request #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#discussion_r410551415
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##########
 @@ -74,7 +75,13 @@ class CarbonEnv {
 
     sparkSession.udf.register("getTupleId", () => "")
     sparkSession.udf.register("getPositionId", () => "")
-    sparkSession.udf.register("NI", (anyRef: AnyRef) => true)
+    CreateFunctionCommand(None,
 
 Review comment:
   please add command before this invocation to explain the modification

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615593921
 
 
   @jackylk handled comments,please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615677558
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2780/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615687231
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1067/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615836320
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1069/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615838327
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2782/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

akashrn5 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615888825
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615912352
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1073/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3718: [CARBONDATA-3680]Add NI as a function not as udf
URL: https://github.com/apache/carbondata/pull/3718#issuecomment-615912675
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2786/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services