[GitHub] [carbondata] akkio-97 opened a new pull request #3943: [CARBONDATA-4000] Presto select query failure right after firing update query.

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akkio-97 commented on pull request #3943: [CARBONDATA-4000] Presto select query failure right after firing update query.

GitBox

akkio-97 commented on pull request #3943:
URL: https://github.com/apache/carbondata/pull/3943#issuecomment-696750855






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akkio-97 removed a comment on pull request #3943: [CARBONDATA-4000] Presto select query failure right after firing update query.

GitBox
In reply to this post by GitBox

akkio-97 removed a comment on pull request #3943:
URL: https://github.com/apache/carbondata/pull/3943#issuecomment-696750855


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3943: [CARBONDATA-4000] Presto select query failure right after firing update query.

GitBox
In reply to this post by GitBox

akkio-97 commented on a change in pull request #3943:
URL: https://github.com/apache/carbondata/pull/3943#discussion_r492730939



##########
File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/ColumnarVectorWrapperDirectWithDeleteDeltaAndInvertedIndex.java
##########
@@ -78,6 +80,17 @@ public void putNull(int rowId) {
     }
   }
 
+  @Override
+  public void putObject(int rowId, Object obj) {
+    if (!deletedRows.get(rowId)) {
+      if (nullBits.get(rowId)) {
+        columnVector.putNull(counter++);

Review comment:
       Have raised a separate jira to address this issue - CARBONDATA-4004




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3943: [CARBONDATA-4000] Presto select query failure right after firing update query.

GitBox
In reply to this post by GitBox

CarbonDataQA1 commented on pull request #3943:
URL: https://github.com/apache/carbondata/pull/3943#issuecomment-696747560






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] asfgit closed pull request #3943: [CARBONDATA-4000] Presto select query failure right after firing update query.

GitBox
In reply to this post by GitBox

asfgit closed pull request #3943:
URL: https://github.com/apache/carbondata/pull/3943


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


12